Re: New serial speed handling: First implementation

From: Alan Cox
Date: Fri Aug 25 2006 - 16:20:41 EST


Ar Gwe, 2006-08-25 am 18:41 +0100, ysgrifennodd Russell King:
> On Fri, Aug 25, 2006 at 04:15:53PM +0100, Alan Cox wrote:
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h
> > --- linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-21 14:17:52.000000000 +0100
> > +++ linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-25 11:23:20.000000000 +0100
> > @@ -47,6 +47,12 @@
> > #define TIOCSBRK 0x5427 /* BSD compatibility */
> > #define TIOCCBRK 0x5428 /* BSD compatibility */
> > #define TIOCGSID 0x5429 /* Return the session ID of FD */
> > +
> > +#define TCGETS2 0x542A
> > +#define TCSETS2 0x542B
> > +#define TCSETSW2 0x542C
> > +#define TCSETSF2 0x542D
> > +
>
> Wouldn't it be better to use the _IO* macros to define these new ioctls?
> Ditto for other architectures.

That really is up to you. For x86/x86-64 it would break the internal
consistency.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/