Re: [PATCH 04/17] BLOCK: Separate the bounce buffering code from the highmem code [try #2]

From: Christoph Hellwig
Date: Fri Aug 25 2006 - 10:10:02 EST


> --- /dev/null
> +++ b/mm/bounce.c
> @@ -0,0 +1,302 @@
> +/* bounce.c: bounce buffer handling for block devices
> + *
> + * - Split from highmem.c
> + */

please don't mention the filename in the top of file comment, it's redundant
and get out of sync too easily on renames. Otherwise the patch looks good.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/