Re: [PATCH] NFS: Check lengths more thoroughly in NFS4 readdir XDRdecode

From: Trond Myklebust
Date: Thu Aug 24 2006 - 16:02:38 EST


On Thu, 2006-08-24 at 20:45 +0100, David Howells wrote:
> Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
>
> > No. I find that mixture of < and <= is much less easy to read. Besides,
> > the compiler should be able to optimise that for me.
>
> So you don't think they're mathematically equivalent?

The fact that they are mathematically equivalent does not make them
equivalently easy to read.

As long as the compiler is able to optimise it, we should be quite free
to choose one or the other style of code.

I therefore chose the style which explicitly lists the number of 32-bit
words we want to scan.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/