Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2]

[Masayuki Saito]

Thank you for your comment.

Andrew Morton <akpm@xxxxxxxx> wrote:
>On Wed, 23 Aug 2006 20:12:51 +0900
>Masayuki Saito <m-saito@xxxxxxxxxxxxxx> wrote:
>
>> It is the problem that i_flags of xfs_inode has no consistent
>> locking protection.
>> 
>> For the reason, I define a new spin_lock(i_flags_lock) for i_flags
>> of xfs_inode.  And I add this spin_lock for appropriate places.
>
>You could simply use inode.i_lock for this.  i_lock is a general-purpose
>per-inode lock.  Its mandate is "use it for whatever you like, but it must
>always be `innermost'"
>

I think that inode.i_lock isn't appropriate for this case.
Because there is the situation that no inode is attached to an xfs_inode.


Masayuki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/