Re: [PATCH 2.6.18-rc4] aoe [07/13]: jumbo frame support 2 of 2

From: Alan Cox
Date: Fri Aug 18 2006 - 18:35:03 EST


Ar Gwe, 2006-08-18 am 13:39 -0400, ysgrifennodd Ed L. Cashin:
> Signed-off-by: "Ed L. Cashin" <ecashin@xxxxxxxxxx>
>
> Add support for jumbo ethernet frames.
> (This patch follows patch 5.)
>
> diff -upr 2.6.18-rc4-orig/drivers/block/aoe/aoecmd.c 2.6.18-rc4-aoe/drivers/block/aoe/aoecmd.c
> --- 2.6.18-rc4-orig/drivers/block/aoe/aoecmd.c 2006-08-17 16:45:34.000000000 -0400
> +++ 2.6.18-rc4-aoe/drivers/block/aoe/aoecmd.c 2006-08-17 16:45:34.000000000 -0400
> @@ -28,7 +28,7 @@ new_skb(ulong len)
> skb->protocol = __constant_htons(ETH_P_AOE);
> skb->priority = 0;
> skb_put(skb, len);
> - memset(skb->head, 0, len);
> + memset(skb->head, 0, ETH_ZLEN);

You realise the tail of a short packet is cleared by the network drivers
either in software or hardware ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/