Re: [-mm patch] cleanup drivers/ata/Kconfig

[Adrian Bunk]

On Tue, Aug 15, 2006 at 12:51:44AM -0700, Greg KH wrote:
> On Sun, Aug 13, 2006 at 11:01:06PM +0200, Adrian Bunk wrote:
> > On Sun, Aug 13, 2006 at 01:24:54AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.18-rc3-mm2:
> > >...
> > >  git-libata-all.patch
> > >...
> > >  git trees
> > >...
> > 
> > This patch contains the following cleanups:
> > - create a menu for ATA
> > - replace the dependencies on ATA with an "if ATA"
> 
> Why do this?  Are we going to be doing this for all subsystems?
> 
> It seems like a bit of unnecessary churn to me...

The following two are exactly equivalent:

<--  snip  -->

tristate BAR1 "bar1"
	depends on FOO

tristate BAR2 "bar2"
	depends on FOO

<--  snip  -->

if FOO

tristate BAR1 "bar1"

tristate BAR2 "bar2"

endif

<--  snip  -->

I'd say the latter is a bit better, but there's no reason to convert all 
subsystems since the two forms are equivalent.

In this case, I was looking for a way to fix the breakage of the ATA 
menu indentation due to SATA_INTEL_COMBINED, and this is the solution I 
did choose.

> thanks,
> 
> greg k-h

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/