Re: [PATCH 1/1] network memory allocator.

From: Evgeniy Polyakov
Date: Mon Aug 14 2006 - 07:30:55 EST


On Mon, Aug 14, 2006 at 04:22:06AM -0700, David Miller (davem@xxxxxxxxxxxxx) wrote:
> From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
> Date: Mon, 14 Aug 2006 15:04:03 +0400
>
> > /* These elements must be at the end, see alloc_skb() for details. */
> > - unsigned int truesize;
> > + unsigned int truesize, __tsize;
>
> There is no real need for new member.
>
> > - kfree(skb->head);
> > + avl_free(skb->head, skb->__tsize);
>
> Just use "skb->end - skb->head + sizeof(struct skb_shared_info)"
> as the size argument.
>
> Then, there is no reason for skb->__tsize :-)

Oh, my fault - that simple calculation dropped out of my head...

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/