Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

From: Muli Ben-Yehuda
Date: Wed Aug 09 2006 - 05:54:21 EST


On Wed, Aug 09, 2006 at 12:02:39PM +0300, Shem Multinymous wrote:

> If we'll need to lock away ACPI (just matter of time, my guess), we'll
> stumble upon the non-interruptible down()s deep inside in the ACPI
> code. So we can't guarantee and shouldn't promise it's really
> interruptible.

Ok, I concede :-)

> It's not that strange that a function might fail even if it's named
> "do_something()", you know. It's down() that forms an exception - it's
> so simple we know it can't fail.

>From a maintainer point of view, anything that is non-idiomatic is a
pain. Since there is no idiomatic way to express what you want, you
get to choose the idiom.

Cheeers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/