Re: [take6 0/3] kevent: Generic event handling mechanism.

From: Evgeniy Polyakov
Date: Wed Aug 09 2006 - 04:07:02 EST


On Wed, Aug 09, 2006 at 12:58:56AM -0700, David Miller (davem@xxxxxxxxxxxxx) wrote:
> From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
> Date: Wed, 9 Aug 2006 12:02:39 +0400
>
> Evgeniy, it's things like the following that make it very draining
> mentally to review your work.
>
> > * removed AIO stuff from patchset
>
> You didn't really do this, you leave the aio_* syscalls and stubs in
> there, and you also left things like tcp_async_send() in there.

By AIO I meant VFS AIO, not network stuff, exactly that part was frown
upon in reviews.

> All the foo_naio_*() stuff is still in there to.
>
> Please remove all of async business we've asked you to.

So you want to review kevent core only at the first point and postpone
network AIO and the rest implementation after core is correct.
Should I remove poll/timer notifications too?

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/