[PATCH] ACPI: Clear GPE before disabling it

From: Jordan Crouse
Date: Tue Aug 08 2006 - 15:15:09 EST


On AMD Geode BIOSen, we have problems with GPE interrupt storms. The
attached patch resolves that. This should be fine for all implementations,
though.

Jordan
--
Jordan Crouse
Senior Linux Engineer
Advanced Micro Devices, Inc.
<www.amd.com/embeddedprocessors>
[PATCH] ACPI: Clear GPE before disabling it

From: William Morrow <william.morrow@xxxxxxx>

On some BIOSen, the GPE bit will remain set even if it is disabled,
resulting in a interrupt storm. This patch clears the bit before
disabling it.

Signed-off-by: William Morrow <william.morrow@xxxxxxx>
Signed-off-by: Jordan Crouse <jordan.crouse@xxxxxxx>
---

drivers/acpi/events/evgpe.c | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c
index c76c058..1f93b23 100644
--- a/drivers/acpi/events/evgpe.c
+++ b/drivers/acpi/events/evgpe.c
@@ -677,10 +677,22 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
case ACPI_GPE_DISPATCH_METHOD:

/*
- * Disable GPE, so it doesn't keep firing before the method has a
+ * Clear GPE, so it doesn't keep firing before the method has a
* chance to run.
*/
+ status = acpi_hw_clear_gpe(gpe_event_info);
+ if (ACPI_FAILURE(status)) {
+ ACPI_EXCEPTION((AE_INFO, status,
+ "Unable to clear GPE[%2X]",
+ gpe_number));
+ return_UINT32(ACPI_INTERRUPT_NOT_HANDLED);
+ }
+ /*
+ * Disable GPE, so it doesn't keep happen again.
+ */
+
status = acpi_ev_disable_gpe(gpe_event_info);
+
if (ACPI_FAILURE(status)) {
ACPI_EXCEPTION((AE_INFO, status,
"Unable to disable GPE[%2X]",