Re: How to lock current->signal->tty

From: Arjan van de Ven
Date: Tue Aug 08 2006 - 11:08:44 EST


Alan Cox wrote:
The biggest crawly horror I've found so far in auditing the tty locking
is current->signal->tty. The tty layer currently and explicitly protects
this using tty_mutex. The core kernel likewise knows about this.

Unfortunately:
Dquot passes the tty to tty_write_message without locking
arch/ia64/kernel/unanligned seems to write to it without locking

these two have absolutely no business at all using anything tty.... they should
just use printk with KERN_EMERG or whatever
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/