Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload

[Shem Multinymous]

Hi,

On 8/8/06, Pavel Machek <pavel@xxxxxxx> wrote:
> > +     if (hdaps_set_power(0))
> > +             printk(KERN_WARNING "hdaps: cannot power off\n");
> > +     if (hdaps_set_ec_config(0, 1))
> > +             printk(KERN_WARNING "hdaps: cannot stop EC sampling\n");
> > +}
>
> Maybe propagate error value?

I could do that, but both callers will still discard it -- the power
draw change is negligible, and it's not interesting enough to abort
either suspend or module unload.

OK on all remaining comments.

I'll wait a bit for additional comments and then post the revised series.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/