Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

[Muli Ben-Yehuda]

On Tue, Aug 08, 2006 at 12:56:52PM +0000, Pavel Machek wrote:

> > > 	ret = thinkpad_ec_lock();
> > > 	if (ret)
> > > 		return ret;
> > 
> > Just in case someone was going to cut and paste, this will return with
> > the ec_lock taken.
> 
> Well, taking lock failed (hence error return) so I think code is
> correct.

Ugh, I missed that - it's called _lock(), but it's actually
down_interruptible(). Why not just get rid of the wrapper and call
down_interruptible() directly? That makes it obvious what's going on.

Cheers,
Muil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/