Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.
From: Arjan van de Ven
Date: Tue Jul 18 2006 - 06:41:39 EST
On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote:
> On 18 Jul 2006, at 11:27, Arjan van de Ven wrote:
>
> > Hmmm maybe it's me, but something bugs me if a NIC driver is going to
> > send IP level ARP packets... that just feels very very wrong and is a
> > blatant layering violation.... shouldn't the ifup/ifconfig scripts just
> > be fixed instead if this is critical behavior?
>
> Maybe we should be faking this out from our hotplug scripts in the
> control VM, although triggering this from user space is probably a bit
> of a pain. Regardless, the function can be removed from the driver if
> it's too distasteful: it's only a performance 'hack' to get network
> traffic more quickly redirected when migrating a VM between physical
> hosts. Things won't break horribly if it's removed.
that sounds like a perfect job for a udev-kind of notification to
userspace, eg "hey I migrated", and then udev/hotplug can just do this
sending of arps.. maybe they also want to do other things just after a
migration (which sounds entirely reasonable to me) such as renewing the
dhcp lease, resetting the periodic userspace hardware polling timers in
"hal", network manager etc etc...
so it looks entirely useful for me to have a userspace upcall for "post
migration", and once you have that that udev side of things can just do
this...
(question is if you also want a pre-migration upcall; my gut feeling
says "no" because upcalls are async and you may end up running that
upcall on the new physical machine)
Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/