Re: [PATCH] nbd: Check magic before doing anything else

From: Paul Clements
Date: Mon Jul 17 2006 - 11:29:08 EST


Michal Feix wrote:
We should check magic sequence in reply packet before trying to find
request with it's request handle. This also solves the problem with
"Unexpected reply" message beeing logged, when packet with invalid magic
is received.

Right. Again, we can't return NULL after pulling the request off the queue, so we better do this check first.

Andrew, these two look good to me.

Thanks,
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/