Re: crash in aty128_set_lcd_enable on PowerBook

[Benjamin Herrenschmidt]

On Sun, 2006-07-16 at 18:50 +0200, Olaf Hering wrote:
>  On Sun, Jul 16, Olaf Hering wrote:
> 
> > 
> > Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev
> > is NULL. This happens since at least a week. Call trace is:
> > 
> > aty128_set_lcd_enable
> > aty128fb_set_par
> > fbcon_init
> > visual_init
> > take_over_console
> > fbcon_takeover
> > notifier_call_chain
> > blocking_notifier_call_chain
> > register_framebuffer
> > aty128fb_probe
> 
> aty128_init calls register_framebuffer() before it assigns pdev.

Yeah, that looks like some serious bogosity in that code. Care to send a
patch ?

>    2028         if (register_framebuffer(info) < 0)
>    2029                 return 0;
>    2030 
>    2031         par->pm_reg = pci_find_capability(pdev, PCI_CAP_ID_PM);
>    2032         par->pdev = pdev;
>    2033         par->asleep = 0;
>    2034         par->lock_blank = 0;
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@xxxxxxxxxx
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/