Re: [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support

[Gerrit Renker]

Quoting Herbert Xu:
|  >                case SO_NO_CHECK:
|  > -                       sk->sk_no_check = valbool;
|  > +                       /* UDP-Lite (RFC 3828) mandates checksumming,
|  > +                        * hence user must not enable this option.   */
|  > +                       if (sk->sk_protocol == IPPROTO_UDPLITE)
|  > +                               ret = -EOPNOTSUPP;
|  > +                       else
|  > +                           sk->sk_no_check = valbool;
|  
|  Please don't add protocol-specific stuff to generic functions.  In this
|  case why don't you just ignore sk_no_check for UDPLITE as we do for TCP?

Thank you for spotting this -- the UDP-Lite code indeed ignores sk_no_check
and will (if no socket options are set) emulate UDP with sk_no_check = 0. Setting
it to 1 will make no difference; so the above is more not strictly necessary. Will 
remove in next patch.
Any other comments or ideas, please do not hesitate to write. 

-- Gerrit
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/