Re: Problems porting asus_acpi to LED subsystem

From: Pavel Machek
Date: Fri Jul 07 2006 - 09:39:46 EST


On Tue 04-07-06 10:50:40, Thomas Tuttle wrote:
> On July 04 at 04:50 EDT, Pavel Machek hastily scribbled:
> > I _guess_ the LED subsystem can be called from interrupt, and ACPI
> > does not like that. So you probably need to use workqueue to defer
> > setting a bit.
>
> Ew, I would personally think that the LED subsystem should do this
> itself...

That would make LEDs factor 10000 or so slower on reasonable
platforms, sorry. But having flag 'this led needs process context'
might be god thing. Patch welcome.

> Anyway, can you give me a pointer on how to do this? I've never used
> workqueues before. (I've coded a grand total of about 40 lines of
> kernel code, and only about 20 work.)

grep is your friend, or some kernel programming intro.I do not have
any example near. Or maybe kernelnewbies.org.

--
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/