Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu)(UPDATED)

From: Randy.Dunlap
Date: Wed Jul 05 2006 - 22:57:07 EST


On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote:

> Here is a new version of the patch, incorporating code style tips from
> Randy Dunlap <rdunlap@xxxxxxxxxxxx>, and based on 2.6.17-git25, rather
> than 2.6.17.1.
>
> I noticed that there's a Heartbeat LED trigger in the git version. I
> hope this isn't too similar.

I missed at least one thing:

Don't #include <linux/config.h>
That is done automatically now by Kbuild. Source files
should not do it. (you could wait to see if there are other comments. :)

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/