Re: [PATCH 1/2] batch-write.patch

From: Christoph Hellwig
Date: Tue Jul 04 2006 - 07:47:08 EST


On Tue, Jul 04, 2006 at 03:12:56PM +0400, Vladimir V. Saveliev wrote:
>
> > Should this be an address_space_operation or a file_operation?
> >
>
> I was seeking to be minimal in my changes to the philosophy of the code.
> So, it was an address_space operation. Now it is a file operation.

It definitly should not be a file_operation! It works at the address_space
not the much higher file level. Maybe all three should become callbacks
for the generic write routines, but that's left for the future.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/