Re: [PATCH] powerpc:Fix rheap alignment problem

From: Kumar Gala
Date: Sat Jul 01 2006 - 10:34:11 EST



On Jul 1, 2006, at 5:25 AM, Christoph Hellwig wrote:

On Sat, Jul 01, 2006 at 05:21:06PM +1000, Benjamin Herrenschmidt wrote:
On Sat, 2006-07-01 at 14:35 +0800, Linux powerpc wrote:
Yes, it was used for allocating dual port RAM for CPM. And now we are
adding QE support to powerpc arch which need to use rheap(QE is next
generation for CPM). Please see the patches I <leoli@xxxxxxxxxxxxx>
just posted for 8360epb support. Moreover, previous CPM support is
adding to powerpc arch too.

Ok, well, I don't have anything specifically against that code, I was
just wondering if it may not duplicate something we already have (yet
another space allocator basically)...

Yepp. Without looking at the rheap allocator in deatail, any reason
it can't use lib/genalloc.c?

Doing a quick glance at lib/genalloc.c I dont see any reason we couldn't use it. However, Panto will know best, since he wrote rheap.

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/