Re: [PATCH] sched.h: increment TASK_COMM_LEN to 20 bytes

From: Andrew Morton
Date: Fri Jun 30 2006 - 21:33:17 EST


Luben Tuikov <ltuikov@xxxxxxxxx> wrote:
>
> > We do occasionally hit task_struct.comm[] truncation, when people use
> > "too-long-a-name%d" for their kernel thread names. But we seem to manage.
>
> It would be especially helpful if you want to name a task thread
> the NAA IEEE Registered name format (16 chars, globally unique), for things
> like FC, SAS, etc. This way you can identify the task thread with
> the device bearing the NAA IEEE name.
>
> Currently just last character is cut off, since TASK_COMM_LEN is 15+1.
>
> I think incrementing it would be a good thing, plus other things
> may want to represent 8 bytes as a character array to be the name
> of a task thread.

OK, that's a reason. Being able to map a kernel thread onto a particular
device is useful.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/