Re: 2.6.17-mm2 hrtimer code wedges at boot?

[john stultz]

On Thu, 2006-06-29 at 19:07 -0400, Valdis.Kletnieks@xxxxxx wrote:
> On Wed, 28 Jun 2006 13:44:12 +0200, Roman Zippel said:
> 
> > Valdis, could you please add a call to the function below in 
> > __get_realtime_clock_ts() when the problem triggers to print the complete 
> > internal clock state.
> 
> Sorry for the delay, I got distracted by other stuff I'm paid to do.. ;)

Very much understand :) Thanks for the testing!

> Here's what a test reboot got:
> 
>    26.578105] audit(1151617213.106:2): policy loaded auid=4294967295
> [   26.597401] audit(1151617213.070:3): avc:  granted  { load_policy } for  pid=1 comm="init" scontext=system_u:system_r:kernel_t:s0 tcontext=system_u:object_r
> :security_t:s0 tclass=security
> [   26.683670] unexpected nsec: -840940811,1655512912
> [   26.704096] clock tsc: m:4290198220,s:22,cl:42659140158,ci:1595067,xn:18158513697558798592,xi:18446736466713803524,e:3648592523541009408

> That tell you anything?

Its a little after the fact (since things have already gone awry), but
it does show the multiplier is way out of bound.

I suspect the following patch will resolve it. The update callback
hasn't kept up with the changes from Roman, and is a bit useless anyway.
If the TSC is changing frequency, its unstable and we don't want to use
it, so lets just mark it as such and move along.

I'll work on a patch to cleanup the update_callback code, but if this
resolves the issue, it should be the safe short term fix for 2.6.18.

thanks again!
-john

diff --git a/arch/i386/kernel/tsc.c b/arch/i386/kernel/tsc.c
index 7e0d8da..68d23f0 100644
--- a/arch/i386/kernel/tsc.c
+++ b/arch/i386/kernel/tsc.c
@@ -348,22 +348,19 @@ static int tsc_update_callback(void)
 {
 	int change = 0;
 
-	/* check to see if we should switch to the safe clocksource: */
-	if (clocksource_tsc.rating != 50 && check_tsc_unstable()) {
-		clocksource_tsc.rating = 50;
-		clocksource_reselect();
-		change = 1;
-	}
-
 	/* only update if tsc_khz has changed: */
 	if (current_tsc_khz != tsc_khz) {
 		current_tsc_khz = tsc_khz;
-		clocksource_tsc.mult = clocksource_khz2mult(current_tsc_khz,
-							clocksource_tsc.shift);
-		change = 1;
+		/* TSC is chnaging freq, mark tsc as bad */
+		mark_tsc_unstable();
 	}
 
-	return change;
+	/* check to see if we should switch to the safe clocksource: */
+	if (clocksource_tsc.rating != 50 && check_tsc_unstable()) {
+		clocksource_tsc.rating = 50;
+		clocksource_reselect();
+	}
+	return 0;
 }
 
 static int __init dmi_mark_tsc_unstable(struct dmi_system_id *d)



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/