Re: [RFC] Adding queue_delayed_work_on interface for workqueues

[Dave Jones]

On Wed, Jun 28, 2006 at 02:32:42PM -0700, Andrew Morton wrote:

 > > +extern int FASTCALL(queue_delayed_work_on(int cpu, struct workqueue_struct *wq, struct work_struct *work, unsigned long delay));
 > 
 > Please wrap at 80-cols.

fixed up

 > I wouldn't bother making this FASTCALL.  It's an ugly thing, and why this
 > particular function?  And this isn't fastpath stuff.

fixed up

 > > -extern int schedule_delayed_work_on(int cpu, struct work_struct *work, unsigned long delay);
 > > +extern int FASTCALL(schedule_delayed_work_on(int cpu, struct work_struct *work, unsigned long delay));
 > 
 > Ditto.

ditto :)

 > >  }
 > >  
 > > +int fastcall queue_delayed_work_on(int cpu, struct workqueue_struct *wq,
 > > +			struct work_struct *work, unsigned long delay)
 > > +{
 > > +}
 > 
 > Feel free to add some kernel-doc for this function ;)

Venki, I'm lazy and it's past my bedtime, send a follow-up diff please ?

 > > @@ -608,6 +615,7 @@ void init_workqueues(void)
 > >  EXPORT_SYMBOL_GPL(__create_workqueue);
 > >  EXPORT_SYMBOL_GPL(queue_work);
 > >  EXPORT_SYMBOL_GPL(queue_delayed_work);
 > > +EXPORT_SYMBOL_GPL(queue_delayed_work_on);
 > >  EXPORT_SYMBOL_GPL(flush_workqueue);
 > >  EXPORT_SYMBOL_GPL(destroy_workqueue);
 > 
 > Opinions vary a bit, but I think we mostly prefer to put the
 > EXPORT_SYMBOL()s at the site of the thing which is being exported:
 >.. 
 > Then again, it's legit to follow existing local style too.  Someone will
 > come along later and fix it all in a single hit.  Whatever.

That someone was me. I did it as a follow-on for Venki's series.

All pushed out to cpufreq.git

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/