Re: [PATCH 1/2] batch-write.patch

From: Chase Venters
Date: Thu Jun 29 2006 - 17:19:52 EST


On Thu, 29 Jun 2006, Chase Venters wrote:

On Thu, 29 Jun 2006, Hans Reiser wrote:


(patch was attached)


Not quoted because patch isn't inlined, but you're testing for the presence of the batch_write pointer repeatedly in the loop. How about declare a batch_write ptr on the stack and then do your test once, outside of your do { } while (count) loop, and then set it to the generic method (before entering the loop) if the generic method isn't available?
^^^^^^^^^

s/available/overridden/;


Thanks,
Chase

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/