Re: NFS and partitioned md

From: Martin Filip
Date: Thu Jun 29 2006 - 12:00:50 EST


Hi,

Neil Brown píše v Čt 29. 06. 2006 v 13:45 +1000:
> Exactly. 4105 > 256. Such devices need a different format filehandle
> which didn't work until very recently due to a bug (obviously no-one
> tried it until recently).
>
> The patch below fixes the kernel so that this will work.

I'm affraid the problem will be yet somewhere else. I've tried this
patch and the result is totaly same :(


> -----------------------------
> Fixing missing 'expkey' support for fsid type 3
>
> From: Frank Filz <ffilzlnx@xxxxxxxxxx>
>
> Type '3' is used for the fsid in filehandles when the device number
> of the device holding the filesystem has more than 8 bits in either
> major or minor.
> Unfortunately expkey_parse doesn't recognise type 3. Fix this.
>
> (Slighty modified from Frank's original)
>
> Signed-Off-By: Frank Filz <ffilzlnx@xxxxxxxxxx>
> Signed-off-by: Neil Brown <neilb@xxxxxxx>
>
> ### Diffstat output
> ./fs/nfsd/export.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff .prev/fs/nfsd/export.c ./fs/nfsd/export.c
> --- .prev/fs/nfsd/export.c 2006-06-29 11:07:21.000000000 +1000
> +++ ./fs/nfsd/export.c 2006-06-27 18:27:49.000000000 +1000
> @@ -126,7 +126,7 @@ static int expkey_parse(struct cache_det
> if (*ep)
> goto out;
> dprintk("found fsidtype %d\n", fsidtype);
> - if (fsidtype > 2)
> + if (key_len(fsidtype)==0) /* invalid type */
> goto out;
> if ((len=qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
> goto out;
> -

--
Martin Filip
e-mail: nexus@xxxxxxxxxx
ICQ#: 31531391
jabber: nexus@xxxxxxxxxx
www: http://www.smoula.net

_______________________________________
< BOFH Excuse #20: divide-by-zero error >
---------------------------------------
\ ,__,
\ (oo)____
(__) )\
||--|| *

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/