Re: [PATCH 1/3] SELinux: Extend task_kill hook to handle signalssent by AIO completion

[Stephen Smalley]

On Wed, 2006-06-28 at 17:16 -0700, Chris Wright wrote:
> > +	void (*task_getsecid) (struct task_struct * p, u32 * secid);
> 
> Why not just:
> 	u32 (*task_getsecid) (struct task_struct *p);

That's fine, although we should then change the SELinux exports as well
to be consistent (and convert them all to secid rather than sid or
ctxid, and eliminate duplication there that has crept in).  That can be
done by later patch.

> >  	int (*task_kill) (struct task_struct * p,
> > -			  struct siginfo * info, int sig);
> > +			  struct siginfo * info, int sig, u32 secid);
> 
> This breaks the build, which breaks bisection.  Be nice to avoid that
> since there's no reason the patches couldn't split that way.

Not sure how one would split them - they are logically all one change
(change interface and all callers, propagating up the call chain).  The
original split up was just for review purposes, by subsystem.  We can
submit it as a single patch if that is preferable.

-- 
Stephen Smalley
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/