Re: [BUG] Linux-2.6.17-rt3 on arm ixdp465

From: Russell King
Date: Thu Jun 29 2006 - 08:24:20 EST


On Thu, Jun 29, 2006 at 08:09:24AM -0400, Steven Rostedt wrote:
>
>
> On Thu, 29 Jun 2006, Esben Nielsen wrote:
>
> >
> > On Thu, 29 Jun 2006, Milan Svoboda wrote:
> >
> >
> > It seems that dma_unmap_single() on arm contains
> > local_irq_save(flags);
> >
> > unmap_single(dev, dma_addr, size, dir);
> >
> > local_irq_restore(flags);
> >
>
> Yeah I saw this too.
>
> > I don't know the dma code on arm. It doesn't look like a per-cpu code but it
> > seems to me that it is not SMP safe and therefore not preempt-realtime
> > safe, either.
> >
> > The hard thing is to figure out which datastructures exactly is protected
> > by those irq-disable and put in a spinlock..
> >
> > I added Deepak Saxena on CC as he seems to be the last one who touched the
> > file.
> >
>
> Well, the following patch may not be the best but I don't see it being any
> worse than what is already there. I don't have any arm platforms or even
> an arm compiler, so I haven't even tested this patch with a compile. But
> it should be at least a temporary fix.

Guys, look at what's in the latest -git from Linus.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/