Re: [git pull] Input update for 2.6.17

[Linus Torvalds]

On Wed, 28 Jun 2006, Jeff Garzik wrote:

> Linus Torvalds wrote:
> > Anyway, "urb->transfer_buffer" was initialized with
> > 
> > 	urb->transfer_buffer = skb->data;
> > 
> > and I'm pretty damn sure you're supposed to just kfree() it.
> 
> eh?  I would think dev_kfree_skb(), because who knows whether the skb was
> cloned, split, data buffer adjusted, destructors need to be called...

Well, we don't actually have the skb available any more.

> kfree()ing skb->data sounds like a recipe for corruption and crashes...

Yeah. But I didn't actually look very deeply, maybe I mistook the init 
sequence. That said, corruption and crashes is obviously what I see, and 
why I started looking at it ;)

Marcel?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/