Re: [2.6 patch] net/dccp/: possible cleanups

[Ian McDonald]

Comments below:

On 6/29/06, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> This patch contains the following possible cleanups:
> - sysctl.c: the Kconfig rules already disallow CONFIG_SYSCTL=n,
>             there's no need for an additional check
Agree

> - proper extern declarations for some variables in dccp.h
NAK - have sent another patch to shift these to feat.h. Arnaldo is
reviewing patches next week.

> - make the following needlessly global function static:
>   - ipv4.c: dccp_v4_checksum()
Agree

> - #if 0 the following unused functions:
>   - ackvec.c: dccp_ackvector_print()
>   - ackvec.c: dccp_ackvec_print()
>   - output.c: dccp_send_delayed_ack()

NAK on the first two. These are for debugging and DCCP still needs
improving so I think worthwhile having there in short term so we can
quickly call them if needed.

I will leave Arnaldo or Andrea to comment on last one...

Ian
--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/