Re: [PATCH 7/7] bootmem: miscellaneous coding style fixes

[Franck Bui-Huu]

2006/6/27, Dave Hansen <haveblue@xxxxxxxxxx>:
> On Tue, 2006-06-27 at 14:54 +0200, Franck Bui-Huu wrote:
> >  }
> > +
> >  /*
> >   * link bdata in order
> >   */
> >  static void __init link_bootmem(bootmem_data_t *bdata)
> >  {
> >         bootmem_data_t *ent;
> > +
> >         if (list_empty(&bdata_list)) {
>
> I'd discourage you from including too many of these in your patches.
> One or two is probably OK.  But, there are a bunch of them, and it isn't
> clear CodingStyle to have spacing like this either way.  I'd drop them.

IMHO they make the code obviously more readable and obviously do not
add any new bugs. So why drop them ?

--
              Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/