Re: 2.6.17-mm2 hrtimer code wedges at boot?

[Roman Zippel]

Hi,

On Tue, 27 Jun 2006, Roman Zippel wrote:

> On Tue, 27 Jun 2006, Valdis.Kletnieks@xxxxxx wrote:
> 
> > Sorry Roman... This may indeed be a legitimate bugfix, but it doesn't
> > fix the problem I'm seeing.  I've been doing the mm-bisect polka for a bit,
> > and have it narrowed down to this set of patches:
> 
> I'm afraid the problem is somehow related, in the longer boot log one can 
> see the edi counting down, so I think it's likely in timespec_add_ns().
> What's weird is that you can trigger it this easily...

Could you please try the patch below? This should better locate which of 
the values goes wrong.

bye, Roman

---
 kernel/timer.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6-mm/kernel/timer.c
===================================================================
--- linux-2.6-mm.orig/kernel/timer.c	2006-06-27 19:16:13.000000000 +0200
+++ linux-2.6-mm/kernel/timer.c	2006-06-27 19:17:41.000000000 +0200
@@ -834,6 +834,8 @@ static inline void __get_realtime_clock_
 
 	} while (read_seqretry(&xtime_lock, seq));
 
+	if (ts->tv_nsec < 0 || nsecs < 0)
+		printk("unexpected nsec: %ld,%Ld\n", ts->tv_nsec, nsecs);
 	timespec_add_ns(ts, nsecs);
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/