Re: GFS2 and DLM

[Christoph Hellwig]

On Mon, Jun 26, 2006 at 11:03:55PM +0200, Ingo Molnar wrote:
> > the generic file read code so GFS should do so aswell.  And there's a 
> > technical reason for not exporting aswell as the generic file read 
> > interface is far too complicated already.
> 
> GFS is different here mostly due to locking,

If it requires locking there it's sendifle and splice_read implementation
are wrong.

<marketing crap removed>

ocfs2 seems to do pretty well using the generic code here, so there
definitly is a explanation required why gfs can't do the same.

> so i'd reformulate your request as a request to extend the VFS to unify 
> clustering filesystems - which is a nice cleanup goal but not a merge 
> showstopper to me.

duplicating half the generic read code is definitily not okay.  I'm
happy to have a discussion about more or less hacly ways to share the
code mid-term.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/