Re: [patch 2/2] x86_64 PCI: improve extended config space verification

From: Rajesh Shah
Date: Mon Jun 26 2006 - 21:02:32 EST


On Fri, Jun 23, 2006 at 03:43:18PM -0700, Greg KH wrote:
> On Fri, Jun 23, 2006 at 10:30:36PM +0200, Andi Kleen wrote:
> > On Friday 23 June 2006 22:09, rajesh.shah@xxxxxxxxx wrote:
> > > Extend the verification for PCI-X/PCI-Express extended config
> > > space pointer. This patch checks whether the MCFG address range
> > > is listed as a motherboard resource, per the PCI firmware spec.
> > > The old check only looked in int 15 e820 memory map, causing
> > > several systems to fail the verification and lose extended
> > > config space.
> >
> > By adding so much code to it you volunteered to factor the
> > sanity check into a common i386/x86-64 file first.
>
> I agree :)
>
> Also, have you looked at the current -git tree? It also modified some
> stuff in this area? Look at commit
> ead2bfeb7f739d2ad6e09dc1343f0da51feb7f51 for details.
>
OK, I just reposted after moving the code to a common file. I did
check that it compiled against the current -git tree, though the
testing was done with -mm2. This did give me back my extended
config space, but it would also be nice if it made a difference
to the other folks who had reported this problem (CC'd).

thanks,
Rajesh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/