Re: [RFC][PATCH] per-task delay accounting: avoid send without listeners

From: Shailabh Nagar
Date: Mon Jun 26 2006 - 19:36:34 EST


Andrew,

This applies on top of the rollup of -mm (as of 5:39, 26 Jun 06), over 2.6.17,
that you have provided at
http://www.zip.com.au/~akpm/linux/patches/stuff/x.bz2

Using this and not 2.6.17-mm2 due to inclusion of other patches that aren't in -mm2.

This concludes the changes I planned to make and should hopefully address all
the overhead concerns.


Jay,

If there are any remaining overhead issues you see, pls let me know asap.

Thanks,
Shailabh

Shailabh Nagar wrote:
> Don't send taskstats (per-pid or per-tgid) on thread exit when no one is
> listening for such data.
>
> Currently the taskstats interface allocates a structure, fills it in
> and calls netlink to send out per-pid and per-tgid stats regardless of whether
> a userspace listener for the data exists (netlink layer would check for that
> and avoid the multicast).
>
> As a result of this patch, the check for the no-listener case is performed
> early, avoiding the redundant allocation and filling up of the taskstats
> structures.
>
> Signed-off-by: Balbir Singh <balbir@xxxxxxxxxx>
> Signed-off-by: Shailabh Nagar <nagar@xxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/