Re: [PATCH] s390: fix duplicate export of overflow{ug}id

[Serge E. Hallyn]

Quoting Dave Jones (davej@xxxxxxxxxx):
> On Mon, Jun 26, 2006 at 02:31:41PM -0500, Serge E. Hallyn wrote:
>  > overflowuid and overflowgid were exported twice.  Remove the export
>  > from s390_ksyms.c
> 
> There's a gotcha with this.  in kernel/sys.c, we only export those
> symbols if CONFIG_UID16 is set.  iirc, there was some part of
> arch/s390 that expected to use those symbols even if it wasn't set.
> 
> Does everything still link with that option both set and unset ?

It does on my partition; near as I can tell the only use of overflowuid
is in compat_linux.c, which is always compiled in.

Nevertheless a #ifndef CONFIG_UID16 is probably more appropriate?

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/