Re: [2.6 patch] drivers/input/misc/wistron_btns.c: section fixes

[Dmitry Torokhov]

On 6/26/06, Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:
> On Monday 26 June 2006 06:35, Adrian Bunk wrote:
> > This patch contains the following fixes:
> > - it doesn't make sense to mark a variable on the stack as __initdata
> > - struct dmi_ids is using the __init dmi_matched()
>
> Since when did static variables become allocated on stack?

BTW, if I add __intidata to dmi_ids array GCC (3.4.4) bitches at me:

 CC      drivers/input/misc/wistron_btns.o
drivers/input/misc/wistron_btns.c:345: error: dmi_ids causes a section
type conflict
make[1]: *** [drivers/input/misc/wistron_btns.o] Error 1
make: *** [drivers/input/misc/] Error 2

I have to declare it as "static const struct dmi_system_id __initdata
dmi_ids[] = {..." for it to compile successfully, but there is a
comment that we should not use const with __initdata. Although I
checked the assembly oputput and const __initdata endes up in
init.data section - exactly where we want it. Wierd...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/