Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver

[Alessandro Zummo]

On Fri, 23 Jun 2006 18:28:28 +0900 (JST)
Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:

> > > +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd,
> > > +			    unsigned long arg)
> > > +{
> > > +	struct platform_device *pdev = to_platform_device(dev);
> > > +	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> > > +
> > > +	if (pdata->irq < 0)
> > > +		return -ENOIOCTLCMD;
> > 
> >  inappropriate -Exxx . maybe -ENODEV?.
> 
> No, it is intentional.  If irq is not available, I want to fall back
> into emulation in rtc-dev.c.

 maybe you can add a comment explaining this choice

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/