Re: [PATCH] dm: support ioctls on mapped devices: fix with fake file

[Christoph Hellwig]

On Fri, Jun 23, 2006 at 07:38:29PM +0100, Alasdair G Kergon wrote:
> [This applies after all the current dm patches.]

NACK.  You should use ioctl_by_bdev and fix it to fake up the file pointer
instead.  That keeps faking the file pointer in a single place and solves
the problem of NULL file pointers for other cases like the s390 partitioning
code, or various odd filesystems figuring out partition tables by themselves.

For bonus points use a common helper for both blkdev_get and ioctl_by_bdev
that creates the fake struct file.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/