Re: Fault tolerance/bad patch, [was Re: [PATCH 29/30] [PATCH] PCI Hotplug: fake NULL pointer dereferences in IBM Hot Plug Controller Driver]

[Greg KH]

On Fri, Jun 23, 2006 at 10:04:43AM -0500, Linas Vepstas wrote:
> Hi,
> 
> On Mon, Jun 19, 2006 at 02:43:35PM -0700, Greg KH wrote:
> > From: Eric Sesterhenn <snakebyte@xxxxxx>
> > 
> > Remove checks for value, since the hotplug core always provides
> > a valid value.
> > 
> > -	if (hotplug_slot && value) {
> > +	if (hotplug_slot) {
> 
> This may be the wrong place to bring up a philosphical issue,

You are right, it is the wrong place for it, please take stuff like this
elsewhere.

value can not be a null value here, it's an impossiblity as that is how
this interface works.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/