Re: Memory corruption in 8390.c ? (was Re: Possible leaks in networkdrivers)

From: Jeff Garzik
Date: Thu Jun 22 2006 - 04:56:28 EST


Herbert Xu wrote:
On Thu, Jun 22, 2006 at 04:22:22AM -0400, Jeff Garzik wrote:
it if needed. Actually, someone should sift through every instance of
skb_pad on a non-linear skb as they do not fit the reasons why this was
originally created.
Non-linear skbs smaller than ETH_ZLEN seem unlikely.

When I was grepping it seems that a few drivers were using it with
a length other than ETH_ZLEN. I've just done another grep and here
are the potential suspects:

cassini.c
starfire.c
yellowfin.c

That doesn't really invalidate the point :) These drivers are still only padding very small packets.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/