Re: reviewing Ubuntu kernel patches

From: Andrew Morton
Date: Wed Jun 21 2006 - 16:27:34 EST


On Wed, 21 Jun 2006 19:38:41 +0200
Adrian Bunk <bunk@xxxxxxxxx> wrote:

> When Andrew merges some small fix into an existing patch in -mm
> (e.g. "make a function static" or "fix a compile error"), he adds the
> Signed-off-by line of the small fix to the Signed-off-by lines of the
> patch.
>
> But the submitter of the fix does not necessarly have checked the
> legal or technical status of the rest of the patch.
>
> As an example, my only contribution to commit
> 6b3934ef52712ece50605dfc72e55d00c580831a was making signal_cachep
> static, and I do refuse any legal or technical responsibility for
> the rest of the patch (this shouldn't imply the rest of the patch was
> bad - it's simply not me who can is responsible for it).

Yes, nowadays I give the folded-in patch a mini-changelog, as in

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm1/broken-out/slab-kmalloc-kzalloc-comments-cleanup-and-fix.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/