Re: [git pull] ieee1394 tree for 2.6.18

[Linus Torvalds]

On Tue, 20 Jun 2006, Stefan Richter wrote:
> 
> Here are stat and shortlog; not from the actual git tree but from patches as
> they went in. Side notes: The spike in the diffstat is whitespace formatting.
> Sem2mutex and kthread conversions as well as suspend/resume fixes are not
> complete yet.

Ok, I pulled, and pushed out, but this tree is really problematic: the 
authorship info has been dropped entirely, it looks.

Git tries to make it very easy to attribute patches properly (with command 
line switches to do it manually, but also with automated tools like git-am 
etc to do it automatically from emails), and has separate "committer" and 
"author" fields, exactly so that you can see both who did the actual 
patch, and who actually merged it.

The ieee1394 tree doesn't actually do that. Ben Collins shows up as the 
author for all of it.

Yes, the sign-offs look fine, but still, attribution and credit is 
_important_.

So for next time, please spend the effort to get attribution right, ok?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/