Re: cfq-iosched.c:RB_CLEAR_COLOR

From: Linus Torvalds
Date: Tue Jun 20 2006 - 21:02:49 EST




On Tue, 20 Jun 2006, David Miller wrote:
>
> That got removed in Linus's tree today, yet cfq-iosched.c
> still contains a reference to it.
>
> The culprit changeset seems to be 3db3a44.
>
> There were two explicit calls in the cfq-iosched.c file
> to RB_CLEAR_COLOR, only the one in cfq_del_crq_rb() got
> removed so the build fails.

I think the right fix is to just remove the RB_CLEAR_COLOR() call, since
the memset will set everything to 0/NULL, which should be the correct
initialization these days anyway.

David (the other one - dwmw2), pls confirm?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/