Re: [patch -mm 05/20] chardev: GPIO for SCx200 & PC-8736x: putgpio_dump on a diet

From: Andrew Morton
Date: Tue Jun 20 2006 - 01:23:41 EST


On Sat, 17 Jun 2006 12:27:02 -0600
Jim Cromie <jim.cromie@xxxxxxxxx> wrote:

> + u32 config = scx200_gpio_configure(index, ~0, 0);
> +
> + printk(KERN_INFO NAME ": GPIO-%02u: 0x%08lx %s %s %s %s %s %s %s\n",
> + index, (unsigned long) config,
> + (config & 1) ? "OE" : "TS", /* output enabled / tristate */
> + (config & 2) ? "PP" : "OD", /* push pull / open drain */
> + (config & 4) ? "PUE" : "PUD", /* pull up enabled/disabled */
> + (config & 8) ? "LOCKED" : "", /* locked / unlocked */
> + (config & 16) ? "LEVEL" : "EDGE", /* level/edge input */
> + (config & 32) ? "HI" : "LO", /* trigger on rising/falling edge */
> + (config & 64) ? "DEBOUNCE" : ""); /* debounce */
> }

Please use hard tabs.

Casting `config' to ulong isn't needed here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/