Re: [UBUNTU:acpi/ec] Use semaphore instead of spinlock

From: Randy Dunlap
Date: Mon Jun 19 2006 - 20:38:51 EST


Andrew Morton wrote:
> Bongani Hlope <bhlope@xxxxxxxxxx> wrote:
>>> @@ -342,7 +341,10 @@ static int acpi_ec_poll_read(union acpi_
>>> return_VALUE(-ENODEV);
>>> }
>>>
>>> - spin_lock_irqsave(&ec->poll.lock, flags);
>>> + if (down_interruptible(&ec->polling.sem)) {
>> ^^^^
>> isn't this suppose to be: &ec->poll.sem
>
> Good question. Did it get resolved?

I posted a corrected patch that does that.
No responses from the ACPI people.

~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/