Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

From: Christoph Hellwig
Date: Mon Jun 19 2006 - 11:57:06 EST


On Mon, Jun 19, 2006 at 11:20:08AM -0400, Theodore Tso wrote:
> This eliminates the i_blksize field from struct inode and uses default
> value in super->s_blksize. Filesystems that want to provide a
> per-inode st_blksize can do so by providing their own getattr routine
> instead of using the generic_fillattr() function.
>
> Note that some filesystems were providing pretty much random (and
> incorrect) values for i_blksize.

Blease don't add a field to the superblock for the optimal I/O size.
Any filesystem that wants to override it can do so directly in ->getattr.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/