Re: [PATCH] use unlikely() for current_kernel_time() loop

From: Andi Kleen
Date: Wed Jun 07 2006 - 22:28:17 EST


Andreas Dilger <adilger@xxxxxxxxxxxxx> writes:

> Hello,
> I just noticed this minor optimization. current_kernel_time() is called
> from current_fs_time() so it is used fairly often but it doesn't use
> unlikely(read_seqretry(&xtime_lock, seq)) as other users of xtime_lock do.
> Also removes extra whitespace on the empty line above.

It would be better to put the unlikely into the read_seqretry I guess.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/