Re: [PATCH] ignore smp_locks section warnings from init/exit code

[Randy.Dunlap]

On Wed, 7 Jun 2006 16:23:26 -0700 Randy.Dunlap wrote:

> On Wed, 7 Jun 2006 15:40:54 -0700 Andrew Morton wrote:
> 
> > On Thu, 8 Jun 2006 00:31:53 +0200
> > "J.A. Magallón" <jamagallon@xxxxxxx> wrote:
> > 
> > > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x3c)
> > > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x40)
> > > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x44)
> > 
> > Yes, that's a false positive - doing locking from within an __init section.
> > We need to shut that up somehow.
> 
> I currently only see this in an __exit section.
> Here is a patch that fixes it for me.
> J.A., can you test it?

This patch fixes 67 such warnings in allmodconfig for me (x86_64).


> ---
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> 
> Add ".smp_locks" section to whitelist as being safe from
> init and exit sections.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
>  scripts/mod/modpost.c |    2 ++
>  1 files changed, 2 insertions(+)
> 
> --- linux-2617-rc6mm1.orig/scripts/mod/modpost.c
> +++ linux-2617-rc6mm1/scripts/mod/modpost.c
> @@ -852,6 +852,7 @@ static int init_section_ref_ok(const cha
>  		".pci_fixup_final",
>  		".pdr",
>  		"__param",
> +		".smp_locks",
>  		NULL
>  	};
>  	/* Start of section names */
> @@ -923,6 +924,7 @@ static int exit_section_ref_ok(const cha
>  		".exitcall.exit",
>  		".eh_frame",
>  		".stab",
> +		".smp_locks",
>  		NULL
>  	};
>  	/* Start of section names */
> -


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/