Re: [PATCH] RTC: Ensure that time being passed to set_alarm() isvalid.

[Andrew Morton]

On 07 Jun 2006 20:20:55 +0200
Andrew Victor <andrew@xxxxxxxxxxxxx> wrote:

> RTC: Ensure that the time being passed to set_alarm() is valid.
> 
> 
> Signed-off-by: Andrew Victor <andrew@xxxxxxxxxxxxx>
> Signed-off-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> 
> 
> diff -urN -x CVS linux-2.6.17-rc6/drivers/rtc/interface.c
> linux-2.6.17-rc/drivers/rtc/interface.c
> --- linux-2.6.17-rc6/drivers/rtc/interface.c	Tue Jun  6 10:28:05 2006
> +++ linux-2.6.17-rc/drivers/rtc/interface.c	Wed Jun  7 11:46:28 2006
> @@ -129,6 +129,10 @@
>  	int err;
>  	struct rtc_device *rtc = to_rtc_device(class_dev);
>  
> +	err = rtc_valid_tm(&alarm->time);
> +	if (err != 0)
> +		return err;
> +
>  	err = mutex_lock_interruptible(&rtc->ops_lock);
>  	if (err)
>  		return -EBUSY;
> 

More details, please.  How can this situation come about?  Buggy kernel
code?  Userspace action?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/